Artifact
15d57d26a67607d1ee8c822cdc197cc77c5be2b4:
Ticket change
[15d57d26a6]
- New ticket
[3bfff6e03b] Error when creating a branch from checkin that doesn't have checksum in manifest.
by
dmitry
2011-03-15 12:10:52.
D 2011-03-15T12:10:52.318
J comment When\sparent\scheck-in\sdoesn't\shave\san\sR-card\sin\smanifest,\sFossil\sfails\sto\screate\sa\sbranch\sfrom\sthis\scheck-in\swith\serror\s"unable\sto\sinstall\snew\smanifest".\sThis\sis\sbecause\sFossil\screates\smanifest\sfor\sa\snew\sbranch\swhich\scontains\sa\sline:\s"R\s"\s(and\sno\schecksum),\sinstead\sof\snot\sadding\san\sR-card\sat\sall,\sand\smanifest_parse()\sfails\sto\sparse\ssuch\smanifests.\r\n\r\nFix\s(patch\sis\snot\sagainst\stip,\sbut\syou\sget\sthe\sidea):\r\n\r\n<verbatim>\r\n---\ssrc/branch.c\r\n+++\ssrc/branch.c\r\n@@\s-99,11\s+99,13\s@@\r\n\s\s\s\s\s}\r\n\s\s\s\s\sblob_append(&branch,\s"\\n",\s1);\r\n\s\s\s}\r\n\s\s\szUuid\s=\sdb_text(0,\s"SELECT\suuid\sFROM\sblob\sWHERE\srid=%d",\srootid);\r\n\s\s\sblob_appendf(&branch,\s"P\s%s\\n",\szUuid);\r\n-\s\sblob_appendf(&branch,\s"R\s%s\\n",\spParent->zRepoCksum);\r\n+\s\sif(\spParent->zRepoCksum\s){\r\n+\s\s\s\sblob_appendf(&branch,\s"R\s%s\\n",\spParent->zRepoCksum);\r\n+\s\s}\r\n\s\s\smanifest_destroy(pParent);\r\n\s\r\n\s\s\s/*\sAdd\sthe\ssymbolic\sbranch\sname\sand\sthe\s"branch"\stag\sto\sidentify\r\n\s\s\s**\sthis\sas\sa\snew\sbranch\s*/\r\n\s\s\sif(\szColor!=0\s){\r\n</verbatim>
J private_contact 05f652db744266759b20d248ec2f451629420388
J severity Important
J status Open
J title Error\swhen\screating\sa\sbranch\sfrom\scheckin\sthat\sdoesn't\shave\schecksum\sin\smanifest
J type Code_Defect
K 3bfff6e03bcc5f14cbd0428cd796a0d109b5ae17
U dmitry
Z eabfbc9636c446e02465e4e9e2939397