Artifact
3d071d49fa953dacac3c65d84236a3e6954099b5:
Ticket change
[3d071d49fa]
- Ticket
[6dba56543b] fossil ticket --quote segfaults when adding to the comment status still Open with 1 other change
by
drh
2012-08-08 11:21:37.
D 2012-08-08T11:21:37.162
J comment <pre>\r\n$\sfossil\snew\sfoo.fossil\r\n...\r\n$\sfossil\sticket\s-R\sfoo.fossil\sadd\stitle\stest\r\nticket\sadd\ssucceeded\sfor\sUID\sa0e7afe56ceaf2e28dfa79bc1db34aa2a767e7c1\r\n$\sfossil\sticket\s-R\sfoo.fossil\schange\sa0e7afe56\scomment\s'foo'\s--quote\r\nticket\sset\ssucceeded\sfor\sUID\sa0e7afe56ceaf2e28dfa79bc1db34aa2a767e7c1\r\n$\sfossil\sticket\s-R\sfoo.fossil\schange\sa0e7afe56\s+comment\s'foo'\s--quote\r\nsegmentation\sfault\r\n</pre>\r\n\r\n<hr\s/><i>mistachkin\sadded\son\s2012-08-08\s03:47:31\sUTC:</i><br\s/>\r\nReading\sthe\scode,\sI'm\ssomewhat\sconfused\sabout\sthe\sproposed\sfix.\s\sPerhaps\sit\sbe\ssomething\slike\sthis\sinstead,\sgiven\sthe\snature\sof\sthe\sother\s<b>if</b>\sblock\senclosed\swith\s<b>if(\stktEncoding\s==\stktFossilize\s)</b>?\r\n\r\n<verbatim>\r\nIndex:\ssrc/tkt.c\r\n==================================================================\r\n---\ssrc/tkt.c\r\n+++\ssrc/tkt.c\r\n@@\s-1167,11\s+1167,11\s@@\r\n\s\s\s\s\s\s\s\s\s}else{\r\n\s\s\s\s\s\s\s\s\s\s\sblob_appendf(&tktchng,\s"J%s%s\s%#F\\n",\szPfx,\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sazField[i],\sstrlen(zValue),\szValue);\r\n\s\s\s\s\s\s\s\s\s}\r\n\s\s\s\s\s\s\s\s\sif(\stktEncoding\s==\stktFossilize\s){\r\n-\s\s\s\s\s\s\s\s\s\sfree(azValue[i]);\r\n+\s\s\s\s\s\s\s\s\s\sfree(zFValue);\r\n\s\s\s\s\s\s\s\s\s}\r\n\s\s\s\s\s\s\s}\r\n\s\s\s\s\s\s\sblob_appendf(&tktchng,\s"K\s%s\\n",\szTktUuid);\r\n\s\s\s\s\s\s\sblob_appendf(&tktchng,\s"U\s%F\\n",\szUser);\r\n\s\s\s\s\s\s\smd5sum_blob(&tktchng,\s&cksum);\r\n</verbatim>\r\n\r\n\r\n<hr\s/><i>rmax\sadded\son\s2012-08-08\s11:18:20\sUTC:</i><br\s/>\r\nIndeed,\sthe\sdistinction\swhether\sit\sis\sazAppend[i]\sor\sazValue[i]\sthat\sneeds\sto\sbe\sfreed\sis\salready\sbeing\smade\stwo\sif\sblocks\sabove,\sso\swe\sdon't\sneed\sto\srepeat\sit\shere\sand\scan\sjust\sfree\szValue.
K 6dba56543b89dc41463174c63c9f11e798c9cfb4
U drh
Z 033a5ed5e27b3426657d65b8cb82da24