Artifact [514070952a]
Not logged in

Artifact 514070952ad441b9ba992a6862eff71e89cfacd8:

Ticket change [514070952a] - Open ticket [40d9dbd3ad]: ssh scheme incompatible with tcsh plus 2 other changes by anonymous 2011-03-28 19:29:18.
D 2011-03-28T19:29:18.078
J +comment \n\n<hr\s/><i>anonymous\sclaiming\sto\sbe\sseanc\sadded\son\s2011-03-28\s19:29:18\sUTC:</i><br\s/>\nI\sdisagree\sthat\sthis\sis\san\sexternal\sbug.\r\n\r\nfossil\scould/should\sexecute\sthe\s/bin/sh\scommand\sas\sits\scommand\sto\sexecute\son\sthe\sremote\sside\sbecause\sfossil\sis\srequiring\sa\sparticular\sshell,\sin\sthis\scase,\ssh.\r\n\r\nOr,\sif\sthat's\snot\spossible,\shave\sit\sfire\soff\san\s'exec\sbin/sh'\sas\sits\sfirst\scommand\supon\sestablishing\san\sssh\sconnection.\sSomething\slike\s(one\sof\sthe\stwo\soptions\sshould\swork\s-\sdry\scoded,\sunfortunately):\r\n\r\n<verbatim>Index:\ssrc/http_transport.c\r\n===================================================================\r\n---\ssrc/http_transport.c\r\n+++\ssrc/http_transport.c\r\n@@\s-147,17\s+147,23\s@@\r\n\s\s\s\s\s}else{\r\n\s\s\s\s\s\s\szHost\s=\smprintf("%s",\sg.urlName);\r\n\s\s\s\s\s}\r\n\s\s\s\s\sblob_append(&zCmd,\s"\s",\s1);\r\n\s\s\s\s\sshell_escape(&zCmd,\szHost);\r\n+\s\s\s\sblob_append(&zCmd,\s"\s",\s1);\r\n+\s\s\s\sshell_escape(&zCmd,\s"/bin/sh");\r\n\s\s\s\s\sprintf("\s%s\\n",\szHost);\s\s/*\sShow\sthe\sconclusion\sof\sthe\sSSH\scommand\s*/\r\n\s\s\s\s\sfree(zHost);\r\n\s\s\s\s\spopen2(blob_str(&zCmd),\s&sshIn,\s&sshOut,\s&sshPid);\r\n\s\s\s\s\sif(\ssshPid==0\s){\r\n\s\s\s\s\s\s\sfossil_fatal("cannot\sstart\sssh\stunnel\susing\s[%b]",\s&zCmd);\r\n\s\s\s\s\s}\r\n\s\s\s\s\sblob_reset(&zCmd);\r\n+\r\n+\s\s\s\s/*\sStart\ssh(1)\s*/\r\n+\s\s\s\sfprintf(sshOut,\s"exec\s/bin/sh\\n");\r\n+\s\s\s\sfflush(sshOut);\r\n\s\r\n\s\s\s\s\s/*\sSend\san\s"echo"\scommand\sto\sthe\sother\sside\sto\smake\ssure\sthat\sthe\r\n\s\s\s\s\s**\sconnection\sis\sup\sand\sworking.\r\n\s\s\s\s\s*/\r\n\s\s\s\s\sfprintf(sshOut,\s"echo\stest\\n");\r\n\r\n</verbatim>
J resolution Open
J status Open
K 40d9dbd3ade39488a6786cd4588c0915974a9961
U anonymous
Z 922ff4348486b7318fcdd5a0687e1ffe