Artifact
7f0369ed8d886e6d7ad577cef0b0e0553b9be7c8:
Ticket change
[7f0369ed8d]
- New ticket
[5982aa5064] Malformed manifest error when committing non-ascii-named files.
by
anonymous
2011-06-29 10:53:29.
D 2011-06-29T10:53:29.200
J comment Problem\sis\sactual\ssince\scheck-in\s[32ad9a1584]\safter\sclosing\sticket\s[3f0216560679fd41].\sWhen\susing\sonly\sascii\s(ansi)\snames\sall's\sok.\r\n\r\nHow\sto\sreproduce:\r\n<verbatim>\r\n$\sfossil\snew\slocal.fossil\r\nproject-id:\s6ebb7aa8bba00a717242424eb34e5210a90e3551\r\nserver-id:\s\s1f0d2c5e79252d625ddd9db92be893702b4e394a\r\nadmin-user:\sflanker\s(initial\spassword\sis\s"******")\r\n$\sfossil\sopen\slocal.fossil\r\n$\sfossil\sadd\s"Приложение\s3.doc"\r\nADDED\s\sПриложение\s3.doc\r\n$\sfossil\scommit\s-m\s"test"\r\nNew_Version:\sd709fe4fa6e2e544ccdc170bce9ee7025273ce95\r\n$\sfossil\sadd\s123.txt\s\r\nADDED\s\s123.txt\r\n$\sfossil\scommit\s-m\s"test2"\r\nNew_Version:\s8f10304d006b7c39d9ed422985a67604863a4290\r\nfossil:\smanifest\sfile\s(5)\sis\smalformed\r\n</verbatim>\r\n\r\nThe\smost\ssensitive\schange\sin\sthis\scheck-in\swas:\r\n<verbatim>\r\n+int\sfossil_strcmp(const\schar\s*zA,\sconst\schar\s*zB){\r\n+\s\sif(\szA==0\s){\r\n+\s\s\s\sif(\szB==0\s)\sreturn\s0;\r\n+\s\s\s\sreturn\s-1;\r\n+\s\s}else\sif(\szB==0\s){\r\n+\s\s\s\sreturn\s+1;\r\n+\s\s}else{\r\n+\s\s\s\sint\sa,\sb;\r\n+\s\s\s\sdo{\r\n+\s\s\s\s\s\sa\s=\s*zA++;\r\n+\s\s\s\s\s\sb\s=\s*zB++;\r\n+\s\s\s\s}while(\sa==b\s&&\sa!=0\s);\r\n+\s\s\s\sreturn\sa\s-\sb;\r\n\s\s\s}\r\n\s}\r\n</verbatim>\r\n\r\nAuthor\ssaid\sthat\sthis\sfunction\scan\scompare\sstrings\swithout\sconsidering\slocale.\sMaybe\sproblem\sis\shere.
J foundin [32ad9a1584]
J private_contact 5e4b94f2022a3718674d2037a39dd914dce7cdba
J severity Important
J status Open
J title Malformed\smanifest\serror\swhen\scommitting\snon-ascii-named\sfiles
J type Code_Defect
K 5982aa506467d6acd1f426b10ce3eab14e7e79ac
U anonymous
Z 305acb015fef3819da505e368fc94196