Artifact a24e6c20d97713dd69c8944623cb0d0593f9df68:

Ticket change [a24e6c20d9] - New ticket [2245a1e3d0] rm command mistakingly believes files are directories. by anonymous 2010-02-13 05:38:06.

---

D 2010-02-13T05:38:06
J comment <pre>\r\n'fossil\srm\sfile'\scrashes:\r\n(gdb)\swhere\r\n#0\s\s0x91af1e9a\sin\sclosedir$UNIX2003\s()\r\n#1\s\s0x00002d43\sin\sdel_directory_content\s(zDir=0x202b00\s"mdb.mk")\sat\sadd_.c:223\r\n#2\s\s0x00002de9\sin\sdel_cmd\s()\sat\sadd_.c:255\r\n#3\s\s0x00022fb7\sin\smain\s(argc=3,\sargv=0xbffff49c)\sat\smain_.c:258\r\n\r\nmdb.mk\sis\sa\splain\sfile\r\n\r\nSuggested\spatch:\r\n---\ssrc/add.c\r\n+++\ssrc/add.c\r\n@@\s-249,11\s+249,11\s@@\r\n\s\s\sdb_begin_transaction();\r\n\s\s\sfor(i=2;\si<g.argc;\si++){\r\n\s\s\s\s\schar\s*zName;\r\n\s\r\n\s\s\s\s\szName\s=\smprintf("%/",\sg.argv[i]);\r\n-\s\s\s\sif(\sfile_isdir(zName)\s){\r\n+\s\s\s\sif(\sfile_isdir(zName)\s==\s1){\r\n\s\s\s\s\s\s\sdel_directory_content(zName);\r\n\s\s\s\s\s}\selse\s{\r\n\s\s\s\s\s\s\schar\s*zPath;\r\n\s\s\s\s\s\s\sBlob\spathname;\r\n\s\s\s\s\s\s\sfile_tree_name(zName,\s&pathname,\s1);\r\n</pre>
J foundin 95ae79d504
J private_contact e05c4b7600be973bfc338fbb2709b47357780bc8
J severity Important
J status Open
J title rm\scommand\smistakingly\sbelieves\sfiles\sare\sdirectories
J type Code_Defect
K 2245a1e3d058d85ec59c327a932a208109d46d45
U anonymous
Z 1d13cdf783883473968fdac775b6e580