Artifact d9b946d42c6e644b5bceb06182fbdc67cda7c073:

Ticket change [d9b946d42c] - New ticket [c9d454153e] Bad find_filename_changes. by anonymous 2011-01-04 10:41:41.

---

D 2011-01-04T10:41:41
J comment While\sinvestigating\s[74413366fe],\swe\scame\sup\swith\san\sexample\swhere\swe\sfound\sa\sbad\sbehaviour\sof\sfind_filename_changes.\sNotice:\r\n\r\n<verbatim>\r\n[llbatlle@comanegra:~/tmp/merge2]$\sfossil\stest-shortest-path\s3f670219\s2d34c3f538\s\r\n\s\s\s1:\s3f6702192edd\s2011-01-04\s09:43:22\sis\sa\sparent\sof\r\n\s\s\s2:\s2d34c3f5389e\s2011-01-04\s09:43:39\r\n\r\n[llbatlle@comanegra:~/tmp/merge2]$\sfossil\stest-shortest-path\s2d34c3f538\s3f670219\r\n\s\s\s1:\s2d34c3f5389e\s2011-01-04\s09:43:39\sis\sa\schild\sof\r\n\s\s\s2:\s3f6702192edd\s2011-01-04\s09:43:22\r\n\r\n[llbatlle@comanegra:~/tmp/merge2]$\sfossil\stest-name-changes\s3f670219\s2d34c3f538\r\n[a]\s->\s[c]\r\n\r\n[llbatlle@comanegra:~/tmp/merge2]$\sfossil\stest-name-changes\s2d34c3f538\s3f670219\r\n\r\n</verbatim>\r\n\r\nNotice\show\sthe\sname\schange\sis\staken\sin\sone\sdirection,\sand\snot\sin\sthe\sother.\sThose\sare\sdirect\scommits,\sno\smerges\sinvolved.\r\n\r\nThe\sproblem\sis\sin\sthe\sline\sof\sfind_filename_changes()\r\n<verbatim>\r\nfor(p=bisect.pStart->u.pTo;\sp;\sp=p->u.pTo)\r\n</verbatim>\r\n\r\nThis\salways\sskips\sthe\sfirst\scheckin\sof\sthe\schain,\swhile\sit\sshould\sbe\sskipped\sonly\sif\sit\sis\sa\sparent\sof\sthe\snext\scommit.\sSimilarly,\ssome\scommits\s(parent\sof\sboth\sFrom\sand\sTo)\sshould\sbe\sskipped\sas\swell.\r\n\r\nThe\strick\sis\sthat\sthe\scheckin\sid\salways\srefers\sto\s"AFTER\sapplying\sthe\scheckin".
J foundin [79b7902cdd]
J status Open
J title Bad\sfind_filename_changes
J type Code_Defect
K c9d454153eea9690a93fcdddb18730b381403a25
U anonymous
Z e77943d75c9faee8e899c0921c58fed9