Artifact
f1d5901a28b4dadfcafb763cb3609b094c46806f:
Ticket change
[f1d5901a28]
- Fixed ticket
[5a96dd5f52]:
non-portable Makefile plus 2 other changes
by
drh
2011-05-31 13:00:45.
D 2011-05-31T13:00:45.784
J comment Tested\sand\sseemed\sto\swork\swith\sboth\sBSD\smake\sand\sgnu\smake\son\sNetBSD\ssystem.\r\n\r\n<pre>\r\n---\sMakefile\r\n+++\sMakefile\r\n@@\s-58,11\s+58,11\s@@\r\n\s\r\n\s#\sYou\sshould\snot\sneed\sto\schange\sanything\sbelow\sthis\sline\r\n\s###############################################################################\r\n\s#\r\n\s#\sAutomatic\splatform-specific\soptions.\r\n-HOST_OS\s:sh\s=\suname\s-s\r\n+HOST_OS=\s$(uname\s-s)\r\n\s\r\n\sLIB.SunOS=\s-lsocket\s-lnsl\r\n\sLIB\s+=\s$(LIB.$(HOST_OS))\r\n\s\r\n\sTCC.DragonFly\s+=\s-DUSE_PREAD\r\n</pre>\n\n<hr\s/><i>ben\sadded\son\s2011-05-28\s21:08:47\sUTC:</i><br\s/>\nThat\swas\schanged\srecently\sfor\sSolaris\scompatibility.\r\n\r\nAccording\sto\sthe\sNetBSD\sman\spages\sit\sshould\swork\son\sthat\ssystem.\sDid\syou\sencounter\sa\sproblem?\n\n<hr\s/><i>bharder\sadded\son\s2011-05-29\s18:21:17\sUTC:</i><br\s/>\n<pre>\r\nkamloops$\suname\s-a\s\r\nNetBSD\skamloops\s5.99.52\sNetBSD\s5.99.52\s(kamloops)\s#80:\sSat\sMay\s28\s14:09:40\sPDT\s2011\s\sroot@kamloops:/usr/obj/sys/arch/amd64/compile/kamloops\samd64\r\nkamloops$\swhich\smake\r\n/usr/bin/make\r\nkamloops$\smake\r\nmake:\sdon't\sknow\show\sto\smake\ssh.\sStop\r\n\r\nmake:\sstopped\sin\s/home/bch/work/fossil\r\nkamloops$\s\r\n</pre>\r\n\r\nWith\sgnu\smake\s(gmake\son\smy\ssystem),\sbuilds\sfine.\sThe\spatch\sI\ssubmitted\swas\stested\son\smy\ssystem\swith\sboth\sBSD\smake\sand\sGNU\smake\sand\sboth\sbuilt\sfine.\n\n<hr\s/><i>ben\sadded\son\s2011-05-30\s07:21:37\sUTC:</i><br\s/>\nI've\screated\sa\sconfigure-make\sbranch\swhich\sadds\sa\s./configure\sstep\sto\sbuilding,\sand\sremoves\sthe\snon-cross-platform\srequirement\sfor\sthe\sMakefile\sto\sset\sa\svariable\sto\sthe\soutput\sof\sa\sshell\scommand.\r\n\r\nThis\swill\sbreak\sany\spackaging\sscripts,\swhich\sis\sunfortunate.\sI'm\snot\ssure\sthere's\san\salternative\sother\sthan\schoosing\sa\splatform\swhich\srequires\spatching\sto\sbuild\s--\swhich\smay\sbe\scompletely\sacceptable\sif\sthat\splatform\sis\sa\sminority\splatform.\s(revert\s[9ef38b6b6d]\sand\sbreak\sSolaris?)\n\n<hr\s/><i>ben\sadded\son\s2011-05-30\s07:28:45\sUTC:</i><br\s/>\nBTW,\sI\stried\sthe\salternative\ssynax\ssuggested\sin\sthe\sticket.\sWhile\sit\sworks\son\sSolaris,\sit\sdoesn't\swork\son\sFreeBSD.\sNo\serror,\sbut\sit\sdoesn't\sinclude\sthe\sextra\s-DUSE_PREAD\sfor\sthe\scompiler.\n\n<hr\s/><i>drh\sadded\son\s2011-05-30\s12:52:50\sUTC:</i><br\s/>\nNo\sconfigure\sscripts,\splease.\s\sIf\sno\smakefile\scan\sbe\sdevised\sthat\sworks\sfor\r\nSolaris\sand\sNetBSD,\sthen\swe'll\screate\sseparate\sMakefile.solaris\sand\sMakefile.netbsd\sfiles\sfor\sthose\splatforms.\n\n<hr\s/><i>ben\sadded\son\s2011-05-30\s16:49:12\sUTC:</i><br\s/>\nI've\scommitted\sa\sMakefile\swhich\sworks\son\s(at\sleast)\sMac\sOS\sX,\sLinux,\sFreeBSD,\sNetBSD\sand\sSolaris.\r\n\r\nFor\sthe\s*BSDs\sand\sSolaris,\sit\swon't\swork\sif\sGNU\smake\sis\sused.\sHowever,\sthis\sis\sno\sworse\sthan\sit\swas\sbefore\sI\smessed\swith\sit\sto\sget\sit\sto\swork\sunder\sSolaris.\n\n<hr\s/><i>joerg\sadded\son\s2011-05-30\s16:51:59\sUTC:</i><br\s/>\nWell,\sthe\soriginal\ssyntax\swas\sworking\swith\sall\smodern\smake\simplementations.\sOnly\sthe\sbroken\smake\son\sSolaris\shas\sissues\swith\sit.\sI'm\squite\smore\sin\sfavour\sof\sjust\saccepting\sthat\sSolaris\suserland\sis\sbroken...\n\n<hr\s/><i>ben\sadded\son\s2011-05-30\s17:10:40\sUTC:</i><br\s/>\nThe\soriginal\ssyntax\swasn't\sworking\swith\sa\s'modern'\sGNU\smake,\sbut\sthat\sdidn't\smatter\sas\sit's\sonly\sthe\snon-GNU\splatforms\swhich\sneed\sthese\stweaks.\s(You'd\sonly\sget\sa\sbuild\sas\sintended\son\sthose\splatforms\sif\syou\sused\sthe\snormal\smake,\snot\sgmake.)\n\n<hr\s/><i>anonymous\sclaiming\sto\sbe\smgagnon\sadded\son\s2011-05-31\s02:31:49\sUTC:</i><br\s/>\nI\sconfirm,\son\sversion\s[3abab7e177]\smakefile\stested\sand\swork\swith\sno\sproblem\son:\r\n\r\n\s\s-\sOpenBSD\s4.9\susing\sbsd\smake\sand\sgnu\smake\r\n\r\n\s\s-\sQNX\s6.4.1\s(which\suse\sgnu\smake)\r\n\s\r\nSo,\sit\sseems\sto\sbe\sthe\sway\sto\sgo.
J resolution Fixed
J status Fixed
K 5a96dd5f528606db7addd8156bb7b5d5fdda158f
U drh
Z 0daccd297dcbd07ebe58ce1bb2d9e982