Ticket Change Details
Not logged in
Overview

Artifact ID: 1cc89153d398e1746c7b1148b094206982325608
Ticket: 006e1df642d6246a03dc5a3c8db122cc64fda176
Error in file_tempname
User & Date: anonymous 2011-06-17 10:54:12
Changes

  1. comment changed to:
    When "gdiff-command" settings is not empty, Fossil is hungup in
    <verbatim>
    fossil gdiff -r revision --to revision filename
    </verbatim>
    
    Error in file.c, in file_tempname function.
    Piece of diff in file.c:
    
    <verbatim>
       /* Check that the output buffer is large enough for the temporary file
    @@ -653,11 +656,11 @@
         sqlite3_randomness(15, &zBuf[j]);
         for(i=0; i<15; i++, j++){
           zBuf[j] = (char)zChars[ ((unsigned char)zBuf[j])%(sizeof(zChars)-1) ];
         }
         zBuf[j] = 0;
    -  }while( access(zBuf,0)==0 );
    +  }while( file_size(zBuf)<0 );
     }
    </verbatim>
    
    Must be
    
    <verbatim>
    while( file_size(zBuf)>=0 );
    </verbatim>
    
  2. foundin changed to: "Check-in [48f5dadafd]"
  3. private_contact changed to: "ed685438f367f4147cdb8507d634250f1fbc14d6"
  4. severity changed to: "Critical"
  5. status changed to: "Open"
  6. title changed to: "Error in file_tempname"
  7. type changed to: "Code_Defect"