Ticket Change Details
Not logged in
Overview

Artifact ID: 3953c975fca0e277eff5b64cc433310bf15dfb82
Ticket: 03fec0ab6021c776a4b3701a33bf88f179fb0b5d
Unlike 'fossil extras', 'fossil clean' doesn't consider case-sensitivity
User & Date: anonymous 2012-11-02 18:55:10
Changes

  1. comment changed to:
    On a case-insensitive filename platform such as Windows, 'fossil clean' may prompt to delete files that aren't reported by running 'fossil extras'. I would expect 'clean' only to prompt to delete the same files listed by 'extras'.
    
    In checkin.c, the function clean_cmd() appears to generate a file list using:
      db_multi_exec("CREATE TEMP TABLE sfile(x TEXT PRIMARY KEY)");
    
    While the function extra_cmd() uses:
    db_multi_exec("CREATE TEMP TABLE sfile(x TEXT PRIMARY KEY %s)",
                    filename_collation());
    
    So I think the fix is to use filename_collation() in clean_cmd() too.
    
    In my repository, the two files that 'clean' prompts for deletion were originally added under a "docs" sub-folder that has since become "Docs".
    
    Thanks
    Mark.
    
  2. foundin changed to: "1.24"
  3. private_contact changed to: "67aadfe5f22f1ea223577cb8273772921fb9baf4"
  4. severity changed to: "Important"
  5. status changed to: "Open"
  6. title changed to:
    Unlike 'fossil extras', 'fossil clean' doesn't consider case-sensitivity
    
  7. type changed to: "Code_Defect"