Ticket Change Details
Not logged in
Overview

Artifact ID: 71f73ca0d112fddf434a37ec1b3a5017070b46c7
Ticket: 986daabbc4b969dd22dc93d183b566f7faf004f9
checkin command lost merge information if --force option used.
User & Date: anonymous 2010-10-19 06:48:59
Changes

  1. comment changed to:
    version [f1d309ccd7] or later, checkin --force option disable clock skew alarm.<br>But if this option specified, checkin_cmd() skip append merged IDs to manifest's "P" card.<br>It must not skip collect IDs from vmerge table even forceFlag is set.<br><blockquote><verbatim>--- ../7954ccba68/src/checkin.c	2010-10-19 00:28:10.437308800 UTC
    +++ src/checkin.c	2010-10-19 15:25:37.979195200 UTC
    @@ -826,23 +826,26 @@
       db_finalize(&q);
       zUuid = db_text(0, "SELECT uuid FROM blob WHERE rid=%d", vid);
       blob_appendf(&manifest, "P %s", zUuid);
    -
    -  if( !forceFlag ){
    -    checkin_verify_younger(vid, zUuid, zDate);
    -    db_prepare(&q2, "SELECT merge FROM vmerge WHERE id=:id");
    -    db_bind_int(&q2, ":id", 0);
    -    while( db_step(&q2)==SQLITE_ROW ){
    -      int mid = db_column_int(&q2, 0);
    -      if( !g.markPrivate && content_is_private(mid) ) continue;
    -      zUuid = db_text(0, "SELECT uuid FROM blob WHERE rid=%d", mid);
    -      if( zUuid ){
    -        blob_appendf(&manifest, " %s", zUuid);
    -        checkin_verify_younger(mid, zUuid, zDate);
    -        free(zUuid);
    -      }
    -    }
    -    db_finalize(&q2);
    -  }
    +  if( !forceFlag ){
    +    checkin_verify_younger(vid, zUuid, zDate);
    +  }
    +
    +  db_prepare(&q2, "SELECT merge FROM vmerge WHERE id=:id");
    +  db_bind_int(&q2, ":id", 0);
    +  while( db_step(&q2)==SQLITE_ROW ){
    +    int mid = db_column_int(&q2, 0);
    +    if( !g.markPrivate && content_is_private(mid) ) continue;
    +    zUuid = db_text(0, "SELECT uuid FROM blob WHERE rid=%d", mid);
    +    if( zUuid ){
    +      blob_appendf(&manifest, " %s", zUuid);
    +      if( !forceFlag ){
    +        checkin_verify_younger(mid, zUuid, zDate);
    +      }
    +      free(zUuid);
    +    }
    +  }
    +  db_finalize(&q2);
    
       blob_appendf(&manifest, "\n");
       blob_appendf(&manifest, "R %b\n", &cksum1);
    </verbatim></blockquote>
    
  2. foundin changed to: "[f1d309ccd7] 2010-08-29 00:21:09"
  3. private_contact changed to: "6b7d8d19b3584e0b0b59ee79d0f778ecd9f60111"
  4. severity changed to: "Cosmetic"
  5. status changed to: "Open"
  6. title changed to:
    checkin command lost merge information if --force option used.
    
  7. type changed to: "Code_Defect"