Ticket Change Details
Not logged in
Overview

Artifact ID: abf3dba780212fed8bbf414df0a170c7322f4870
Ticket: 538d51575deedc883c37b8f373cf4ddc368f8893
Recursive rm doesn't work
User & Date: anonymous 2010-08-11 01:03:39
Changes

  1. comment changed to:
    Deletes done on a subdirectory don't make it into the commit set.
    <pre>
    mike /Users/mike/temp/11/db-4.2.52 $ fossil status
    repository:   /Users/mike/temp/11/x
    local-root:   /Users/mike/temp/11/
    server-code:  91fc8a118b8bdbc657cde65291f00826ada2e4d2
    checkout:     398f524c8fdc5ee7ddcb5667f714fc773431dc0e 2010-08-11 00:24:39 UTC
    parent:       e8e391df27dc580a3cdcfe43823d709258053400 2010-08-11 00:19:33 UTC
    tags:         trunk
    mike /Users/mike/temp/11/db-4.2.52 $ fossil rm xa
    DELETED  xa/tags
    DELETED  xa/xa.c
    DELETED  xa/xa_db.c
    DELETED  xa/xa_map.c
    mike /Users/mike/temp/11/db-4.2.52 $ fossil status
    repository:   /Users/mike/temp/11/x
    local-root:   /Users/mike/temp/11/
    server-code:  91fc8a118b8bdbc657cde65291f00826ada2e4d2
    checkout:     398f524c8fdc5ee7ddcb5667f714fc773431dc0e 2010-08-11 00:24:39 UTC
    parent:       e8e391df27dc580a3cdcfe43823d709258053400 2010-08-11 00:19:33 UTC
    tags:         trunk
    mike /Users/mike/temp/11/db-4.2.52 $ fossil commit -m "test"
    fossil: nothing has changed
    </pre>
    Had I done <tt>fossil rm xa/*</tt> the delete is added to the commits correctly.  Suggested patch:
    <pre>
    Index: src/add.c
    ===================================================================
    --- src/add.c
    +++ src/add.c
    @@ -213,11 +213,11 @@
             if( !db_exists(
                 "SELECT 1 FROM vfile WHERE pathname=%Q AND NOT deleted", zFilePath)
             ){
               printf("SKIPPED  %s\n", zPath);
             }else{
    -          db_multi_exec("UPDATE vfile SET deleted=1 WHERE pathname=%Q", zPath);
    +          db_multi_exec("UPDATE vfile SET deleted=1 WHERE pathname=%Q", zFilePath);
               printf("DELETED  %s\n", zPath);
             }
             blob_reset(&pathname);
           }
           blob_resize(&path, origSize);
    </pre>
    
  2. foundin changed to: "1d713f3f4d"
  3. private_contact changed to: "e05c4b7600be973bfc338fbb2709b47357780bc8"
  4. severity changed to: "Important"
  5. status changed to: "Open"
  6. title changed to: "Recursive rm doesn't work"
  7. type changed to: "Code_Defect"