Ticket Change Details
Not logged in
Overview

Artifact ID: c028cad4ba05d575cc959316646fe3dc8847b492
Ticket: 82cd90df7b2f2a176fa00468b3a740f82c97ded9
fossil bisect segfault
User & Date: anonymous 2011-03-30 17:50:15
Changes

  1. comment changed to:
    fossil bisect <no args>
    Segmentation fault (core dumped)
    
    strlen(NULL) is a bad idea, at least on OpenBSD and Solaris:-)
    
        - mho
    
    Index: src/bisect.c
    ===================================================================
    --- src/bisect.c
    +++ src/bisect.c
    @@ -88,10 +88,13 @@
     */
     void bisect_cmd(void){
       int n;
       const char *zCmd;
       db_must_be_within_tree();
    +  if (g.argc < 3) {
    +    usage("bad|good|next|reset|vlist ...");
    +  };
       zCmd = g.argv[2];
       n = strlen(zCmd);
       if( n==0 ) zCmd = "-";
       if( memcmp(zCmd, "bad", n)==0 ){
         int ridBad;
    
  2. foundin changed to: "51759d5248"
  3. private_contact changed to: "bdc990942928a0418f4d5406ebfe443f98cabed0"
  4. severity changed to: "Cosmetic"
  5. status changed to: "Open"
  6. title changed to: "fossil bisect segfault"
  7. type changed to: "Code_Defect"