The fix for bug only seems to have fixed the issue for the gdiff command. If editor contains spaces, executing it still fails.

<verbatim>
Lean SDMC>fossil commit
c:/Program
260D688DBC8.txt"
'c:/Program' is not recognized as an internal or external command,
operable program or batch file.
editor aborted
</verbatim>

Diff below fixes this, but a better solution would probably be to extend the portable_system command to cover all uses of fossil_system

<verbatim>
--- src/checkin.c
+++ src/checkin.c
@@ -442,11 +442,11 @@
 #if defined(_WIN32)
   blob_add_cr(&text);
 #endif
   blob_write_to_file(&text, zFile);
   if( zEditor ){
-    zCmd = mprintf("%s zEditor, zFile);
+    zCmd = zEditor, zFile);
     printf("%s\n", zCmd);
     if( fossil_system(zCmd) ){
       fossil_panic("editor aborted");
     }
     blob_reset(&text);
</verbatim>