D 2011-01-14T13:59:39.514
J comment According\sto\sMicrosoft,\s_open_osfhandle\sis\sdeclared\sas\sfollows:\r\n\r\n<verbatim>\r\n\s\sint\s_open_osfhandle\s(\r\n\s\s\s\sintptr_t\sosfhandle,\r\n\s\s\s\sint\sflags\s\r\n\s\s);\r\n</verbatim>\r\n\r\nHowever,\sFossil\scurrently\scalls\sthis\sfunction\sas\sfollow:\r\n\r\n<verbatim>\r\n\s\s\s\s*pfdIn\s=\s_open_osfhandle((long)hStdoutRd,\s0);\r\n\s\s\s\sfd\s=\s_open_osfhandle((long)hStdinWr,\s0);\r\n</verbatim>\r\n\r\nThe\scast\sto\slong\sis\scausing\strouble,\sbecause\son\sx86_64-windows,\r\nlong\sis\sstill\s32bit,\swhereas\sintptr_t\sis\s64bit.\r\n\r\nThe\sattached\spatch\sfixes\sthis.\r\n\r\n--\stsbg
J foundin [4ab7251fcd]
J private_contact 76518fb407f147a1d053c00b5b993281a339c0e3
J severity Severe
J status Open
J title Wrong\scast\sin\scall\sto\s_open_osfhandle
J type Code_Defect
K 6585b6c5d9058212cebc4523012344858f099c1c
U anonymous
Z fb0b6015fd9d3ad3b4dd4a6a5a3da0bc