D 2011-02-08T16:33:37.358
J comment In\sreading\sthrough\supdate.c,\sit\sdoesn't\slook\sas\sthough\supdates\sor\sreverts\swill\sset\sthe\spermissions\sof\sfiles\swhen\srecreating\sthem.\s\sUnlike\scheckout's\scode\spath,\supdate/revert\sdoesn't\scall\scheckout.c:checkout_set_all_exe()\sto\sset\sthe\spermissions\sof\sfiles.\s\sAt\sfirst\sglance,\sit\slooks\slike\sthe\sbest\splace\sto\scheck\sto\ssee\sif\spermissions\sneed\sto\sbe\supdated\sis\svia\svfile.c:vfile_check_signature()\s(in\sthe\scall\spath\sfor\srevert)\sor\sin\svfile.c:vfile_compare_repository_to_disk()\s(not\sused\sother\sthan\sin\scheckin).\r\n\r\nTo\sreproduce:\r\n\r\n<pre>#\sIn\sa\stest\srepository\swith\s`alias\sfs\sfossil`\r\nprintf\s'#\\!/bin/sh\\necho\stest\sscript\sperms\\n'\s>\stest.sh\r\nchmod\s755\stest.sh\r\nfs\sadd\stest.sh\r\nfs\sci\s-m\s"Adding\sa\stest\sscript"\r\nrm\s-f\stest.sh\r\nfs\srevert\stest.sh\r\n#\stest.sh\swill\sbe\smode\s644</pre>
J private_contact 84f59114b7eee7088fd7e2932599c69c9ad0761b
J severity Minor
J status Open
J title update/revert\sdon't\sset\spermissions
J type Code_Defect
K baf9b6b11e08c1d0b151d52dd6392ffcb8d44590
U anonymous
Z dc5a9db044d13cae6eafcbc57ff9152d