| Ticket UUID: | d94b0934861d970a5a0868a9c0962befab60c98d | ||
| Title: | Show events for edited user field in user's timeline | ||
| Status: | Fixed | Type: | Feature_Request |
| Severity: | Minor | Priority: | |
| Subsystem: | Resolution: | Fixed | |
| Last Modified: | 2011-08-23 15:10:41 | ||
| Version Found In: | 1.18 | ||
| Description & Comments: | |||
Currently timeline with u=username argument doesn't show events for which "edited user" has been set to the requested username.
Example:I mistakenly commited [c57830bec2] under username "dchest", while my real username here is "dmitry". I then edited username for this commit, it now shows: Edited user: dmitry However, timeline for "dmitry" doesn't show this commit: http://www.fossil-scm.org/index.html/timeline?u=dmitry It's correctly listed under "dchest", though: http://www.fossil-scm.org/index.html/timeline?u=dchest I propose listing such events in timelines for both original and edited users:
--- src/timeline.c
+++ src/timeline.c
@@ -1081,11 +1081,11 @@
}else if( zType[0]=='e' ){
zEType = "event";
}
}
if( zUser ){
- blob_appendf(&sql, " AND event.user=%Q", zUser);
+ blob_appendf(&sql, " AND (event.user=%Q OR event.euser=%Q)", zUser, zUser);
url_add_parameter(&url, "u", zUser);
zThisUser = zUser;
}
if ( zSearch ){
blob_appendf(&sql,
martin.weber added on 2011-08-23 01:36:42 UTC: dmitry added on 2011-08-23 01:36:52 UTC: | |||