View Ticket
Not logged in
Ticket UUID: 3dbc12f49d069512ce8c4b9da084e851602e356a
Title: Edit ticket fails to save changes if assigned_to AND remark are changed.
Status: Fixed Type: Code_Defect
Severity: Important Priority:
Subsystem: Resolution: Fixed
Last Modified: 2011-09-08 22:08:27
Version Found In: Fossil version [61c52dd6aa] 2010-03-30 14:29:32
Description & Comments:
1. I used instructions from http://www.fossil-scm.org/fossil/doc/tip/www/custom_ticket.wiki to add the assigned_to and opened_by fields to the ticket system.

2. Created new ticket. There is no access to assigned_to field so it defaults to 'unassigned'.

3. Edited this ticket. Changed the assigned_to field to another of the pulldown list values, AND appended a remark in the description and comment field.

4. Clicked on 'Submit Changes'.

5. Result was re-display of view ticket page with neither change made.

6. Edited this ticket again. Changed the assigned_to field again.

7. Clicked on 'Submit Changes'.

8. Result was re-display of view ticket page with the new value of the assigned_to field as expected.

9. Created another new ticket and edited to append text only. This change was accepted with assigned_to remaining as 'unassigned'.

10. Made second edit of ticked to change assigned_to and it was accepted.

It appears that the combination of edits to the two fields cause a failure where single field changes do not.

I did not try other field combinations.


ron added on 2010-04-04 09:57:00:
I don't understand what's going on. I added "-th-trace" to my "fossil ui" on a test repo, and reproduced the problem. Here is the output of the TH trace on submittion:

if {![info exists username]} {set username $login} if {[info exists submit]} { if {[info exists cmappnd]} { if {[string length $cmappnd]>0} { set ctxt "\n\n
[htmlize $login]" if {$username ne $login} { set ctxt "$ctxt claiming to be [htmlize $username]" } set ctxt "$ctxt added on [date]:
\n$cmappnd" append_field comment $ctxt } } submit_ticket } 

 
 Fossil version [251fd001a8c6e7af99500a8ca3ac38ad95577995] 2010-04-02 19:28:00 
 BEGIN_HEADER
 set project_name {JOE}
 set title {Edit Ticket}
 set baseurl {http://localhost:8080}
 set index_page {/home}
 set current_page {tktedit}
 set manifest_version {[251fd001a8c6e7af99500a8ca3ac38ad95577995]}
 set manifest_date {2010-04-02 19:28:00}
 set login {ron}
 BEGIN_HEADER_SCRIPT
 [hascap jor] => 1
 [hascap oh] => 1
 [hascap o] => 1
 [hascap r] => 1
 [hascap j] => 1
 [hascap s] => 1
 END_HEADER
 BEGIN_TKTEDIT
 set CONTENT_LENGTH {228}
 set CONTENT_TYPE {application/x-www-form-urlencoded}
 set GATEWAY_INTERFACE {CGI/1.0}
 set HTTP_HOST {localhost:8080}
 set HTTP_REFERER {http://localhost:8080/tktedit?name=98c889a3cd}
 set HTTP_USER_AGENT {Mozilla/5.0 (compatible; Konqueror/4.4; Linux) KHTML/4.4.2 (like Gecko) Frugalware Linux}
 set PATH_INFO {/tktedit}
 set QUERY_STRING {}
 set REMOTE_ADDR {127.0.0.1}
 set REQUEST_METHOD {POST}
 set REQUEST_URI {/tktedit}
 set assigned_to {ron}
 set cmappnd {adef}
 set csrf {localhost}
 set foundin {}
 set name {98c889a3cd}
 set opened_by {ron}
 set priority {Immediate}
 set private_contact {}
 set resolution {Open}
 set severity {Critical}
 set status {Open}
 set submit {Submit Changes}
 set title {test1}
 set type {Code_Defect}
 set username {ron}
 set tkt_datetime {2010-04-04 09:40:12}
 set tkt_id {1}
 set tkt_uuid {98c889a3cd6b2e555b8dc43dbec8c9b3c3f4e201}
 set tkt_mtime {2455290.90291667}
 set subsystem {}
 set comment {blah}
 set login {ron}
 set date {2010-04-04 09:47:57}
 BEGIN_TKTEDIT_SCRIPT
 append_field comment { <hr><i>ron added on 2010-04-04 09:47:57:</i><br> adef}
 submit_ticket { 
D 2010-04-04T09:47:57
J assigned_to ron
J +comment \n\n<hr><i>ron\sadded\son\s2010-04-04\s09:47:57:</i><br>\nadef
J priority Immediate
J resolution Open
K 98c889a3cd6b2e555b8dc43dbec8c9b3c3f4e201
U ron
Z a9dbf9bb131bee3ff365cace02d69d82


 }
 BEGIN_TKTEDIT
 BEGIN_FOOTER
 END_FOOTER

anonymous added on 2010-11-25 11:21:08:
drh said in the mailing list that it's fixed in [e1dac0e4f6]