View Ticket
Not logged in
Ticket UUID: 5a855f1bc6351f50e9686ca3b95553135fb30fef
Title: "changes", "diff" not properly reporting.
Status: Closed Type: Code_Defect
Severity: Important Priority:
Subsystem: Resolution: Fixed
Last Modified: 2012-01-12 00:35:27
Version Found In: 8a8685d103
Description & Comments:
[8a8685d103] and [058e287edb] both exhibit this issue.

[058e287edb] On merge, "fossil chan" properly displays changed files (2 files). "fossil revert ./onefile", and "fossil chan" displays no files. "fossil diff" displays no files.

[8a8685d103] On merge, (no "revert" applied), neither "fossil chan" nor "fossil diff" report what's expected.


bharder added on 2012-01-06 05:06:00 UTC:
This buggy behaviour began at [b9227b85cb|status improvements].


bharder added on 2012-01-06 06:30:34 UTC:
See [d7ff893259] for branch w/ offending code removed (wholesale). Will need to be reviewed/replaced.


drh added on 2012-01-08 20:18:48 UTC:
The [b9227b85cb|status improvements] was to fix an issue. Perhaps the fix was incorrect. But removing the fix is not right either. The right thing to do is to fix the fix.

Is there an easily reproducible test case that demonstrates the problem with [b9227b85cb|status improvements]?


bharder added on 2012-01-10 17:25:13 UTC:
> Perhaps the fix was incorrect. But removing the fix is not right either.

I agree completely. What I've done here is provide a branch to isolate comparing these differences, and revert the way fossil behaves on the command line (by eliminating that original feature's side-effect); Am hoping to get the original fix back in, w/o it's side-effect, merge back to trunk.


bharder added on 2012-01-12 00:35:27 UTC:
This [bcd718e924|change] appears to work.