Ticket UUID: | 5a96dd5f528606db7addd8156bb7b5d5fdda158f | ||
Title: | non-portable Makefile | ||
Status: | Fixed | Type: | Code_Defect |
Severity: | Important | Priority: | |
Subsystem: | Resolution: | Fixed | |
Last Modified: | 2011-05-31 13:00:45 | ||
Version Found In: | 0448438c56d836a8a8261a | ||
Description & Comments: | |||
Tested and seemed to work with both BSD make and gnu make on NetBSD system.
--- Makefile +++ Makefile @@ -58,11 +58,11 @@ ben added on 2011-05-28 21:08:47 UTC: According to the NetBSD man pages it should work on that system. Did you encounter a problem? bharder added on 2011-05-29 18:21:17 UTC: kamloops$ uname -a NetBSD kamloops 5.99.52 NetBSD 5.99.52 (kamloops) #80: Sat May 28 14:09:40 PDT 2011 root@kamloops:/usr/obj/sys/arch/amd64/compile/kamloops amd64 kamloops$ which make /usr/bin/make kamloops$ make make: don't know how to make sh. Stop With gnu make (gmake on my system), builds fine. The patch I submitted was tested on my system with both BSD make and GNU make and both built fine. ben added on 2011-05-30 07:21:37 UTC: This will break any packaging scripts, which is unfortunate. I'm not sure there's an alternative other than choosing a platform which requires patching to build -- which may be completely acceptable if that platform is a minority platform. (revert [9ef38b6b6d] and break Solaris?) ben added on 2011-05-30 07:28:45 UTC: drh added on 2011-05-30 12:52:50 UTC: ben added on 2011-05-30 16:49:12 UTC: For the *BSDs and Solaris, it won't work if GNU make is used. However, this is no worse than it was before I messed with it to get it to work under Solaris. joerg added on 2011-05-30 16:51:59 UTC: ben added on 2011-05-30 17:10:40 UTC: anonymous claiming to be mgagnon added on 2011-05-31 02:31:49 UTC: - OpenBSD 4.9 using bsd make and gnu make - QNX 6.4.1 (which use gnu make) So, it seems to be the way to go. |