View Ticket
Not logged in
Ticket UUID: 7eab65a85880a10cc17e45c764acbc36bfa783a4
Title: crnl y/N/a unclear
Status: Fixed Type: Code_Defect
Severity: Minor Priority:
Subsystem: Resolution: Fixed
Last Modified: 2011-04-27 14:36:54
Version Found In: bc427ad727
Description & Comments:
this is the first time i've gotten this prompt:
C:/rev/src/trader/src/FactoryBase.cpp contains CR/NL line endings; commit anyhow (y/N/a)?a
New_Version: 32177f91eafbe7f543d667b2cc25d3c7f225b19d

i responded 'a' because i assumed it meant 'abort'. 'a' apparently means 'all'. code inspection also reveals that 'n' would break the loop and not ask you about any more files. so there is currently no way to say 'y' to some files and 'n' to others. you have to commit all or none. i propose that as a minimum, the prompt could be changed to (Yes/No/All) and perhaps be enhanced to (Yes/No/All/Cancel) and allow the user to hit 'n' for a subset of files and continue with committing other files and 'c' would cancel the process.


anonymous claiming to be Ingo Koch added on 2011-04-25 08:08:42 UTC:
I would consider this as a bug, not an incident. The behaviour is different from what the open command does for overwriting files. There an N skips only the file you're asked for and proceeds.

With commit the N breaks the whole commit. A checkin with a CR/LF text file and a binary file commits none of them if N is answered for the text file. I also get an error message:

D:/Daten/Projects/Privat/SharpFossil/Test/testdir/3.txt contains CR/NL line endings; commit anyhow (y/N/a)? N C:\Program Files (x86)\bin\fossil.exe: Abandoning commit due to CR+NL line endings in D:/Daten/Projects/Privat/SharpFossil/Test/testdir/3.txt C:\Program Files (x86)\bin\fossil.exe: SQLITE_BUSY: statement aborts at 2: [ROLLBACK] cannot rollback transaction - SQL statements in progress