View Ticket
Not logged in
Ticket UUID: 9ae4043d8b2d4419609091d08caf1585be0e08f0
Title: Please merge fixes for Solaris 10 into trunk
Status: Fixed Type: Code_Defect
Severity: Critical Priority:
Subsystem: Resolution: Fixed
Last Modified: 2011-05-23 15:07:08
Version Found In: trunk
Description & Comments:
Please merge the solaris10 branch into trunk. This fixes problems on Solaris 10:

* Doesn't build. Makefile used non-standard syntax for getting value of uname -s. Changed to use standard syntax. Checked build on Solaris 10, Mac OS X, FreeBSD and Ubuntu Linux.

* Doesn't support passwords > 8 chars, because getpass() truncates to 8 chars. Fixed by adding conditional #define getpass getpassphrase in config.h

Thanks.


anonymous added on 2011-05-23 03:01:28 UTC:
About the changes in [9ef38b6b6d]:

At least the VAR != shell command is documented in BSD make, but the VAR :sh = shell command sure doesn't seem to be (although it does seem to work with BSD make). In addition, neither syntax works with GNU make. To get the equivalent with GNU make the syntax is VAR = $(shell shell command) instead.


ben added on 2011-05-23 07:07:00 UTC:
Because the makefile has to work with 'all' variations of make with varying compliance to varying standards, the options open are a bit limited. It's only important that shell commands are executed on the platforms using non-GNU makes - the BSDs and Solaris.

A better way would be to start adding to the build system with configure scripts and the like. However, this is a far bigger change and would break anything which assumes you just run make, such as packaging systems.