Ticket UUID: | a534227710d3e560aa47499e6f80f764a6444f7d | ||
Title: | Web UI "Admin -> Sync Now" should be removed except maybe for "fossil ui" | ||
Status: | Fixed | Type: | Code_Defect |
Severity: | Minor | Priority: | |
Subsystem: | Resolution: | Fixed | |
Last Modified: | 2010-04-22 15:22:03 | ||
Version Found In: | [7c37b46b12] 2010-04-15 23:53:15 | ||
Description & Comments: | |||
The fossil web interface provides a "Sync Now" option on the Admin page. However, in order for this to work correctly, the following must all be true:
This breaks down if fossil was started with the "fossil server directory" option (or the corresponding fossil cgi "directory: ..." option). Which repository will get sync'd when you select "Sync Now"? In fact it looks like if the above conditions are true, you'll always sync the same repository which may or may not be related at all to the the repository being viewed via the web ui. However, for the "fossil ui" command only, none of the above applies since a single repository must be specified and it's reasonable to expect the conditions listed above to always be satisfied correctly. Is it possible to just suppress the "Sync Now" option unless the command that started the server was "fossil ui"? P.S. Even when using "fossil ui" to run the "Sync Now" option (and it does work) the sync progress output corrupts the content being returned -- all the progress details from the sync are output before the initial "HTTP/1.0 200 OK" response so it's kind of surprising that the browser even displays the real html content correctly at all (after the mash of sync progress output at the top of the page). It might be simpler just to get rid of the web interface to "Sync Now" completely. drh added on 2010-04-22 15:22:03: |