| Ticket UUID: | d6132e4d66a7c994f950e020a4945c7fb85b5a7b | ||
| Title: | Possibly incorrect column index for isexe in stash_add_file_or_dir | ||
| Status: | Fixed | Type: | Code_Defect |
| Severity: | Minor | Priority: | |
| Subsystem: | Resolution: | Fixed | |
| Last Modified: | 2011-01-17 23:49:28 | ||
| Version Found In: | afc4bf41fa | ||
| Description & Comments: | |||
If I read the code correctly, in stash.c we have the following SQL statement on line 65:
blob_appendf(&sql,
"SELECT deleted, isexe, mrid, pathname, coalesce(origname,pathname)"
" FROM vfile"
" WHERE vid=%d AND (chnged OR deleted OR origname NOT NULL OR mrid==0)",
vid
);
"isexe" is at column 1. But then on lines 97-99: #ifdef _WIN32
db_bind_int(&ins, ":isexe", db_column_int(&q, 2));
#endif
So it will not preserve isexe bit on Windows, but instead use mrid for it. Shouldn't it be like this instead: | |||
View Ticket